Assume match before calling help-xref-button
authorBasil L. Contovounesios <basil@contovou.net>
Tue, 30 Apr 2024 06:31:58 +0000 (08:31 +0200)
committerBasil L. Contovounesios <basil@contovou.net>
Wed, 1 May 2024 10:38:51 +0000 (12:38 +0200)
commit65fa47e3fa15c5553974a6d99080f21b4117245b
tree2dce0534e487caaaa2feda5aa3197b478cdac8f4
parent54dbd8b4fa2253682d044cc53bd658e361bff8a0
Assume match before calling help-xref-button

help-xref-button fails if not preceded by a valid match, so a
preceding unconditional search should not be allowed to fail
silently.

* lisp/emacs-lisp/ert.el (ert-describe-test):
* lisp/help-fns.el (help-fns--compiler-macro)
(help-fns-function-description-header, describe-variable)
(help-fns--customize-variable, describe-face)
(help-fns--face-attributes, describe-keymap): Let unconditional
re-search-backward before help-xref-button fail early, as that would
indicate a logic bug, and the backtrace would more accurately point
to the actual source of the mistake.
lisp/emacs-lisp/ert.el
lisp/help-fns.el